fix: dark theme support in stories #1950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a01258a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Adzouz
added
pr: fix
Adzouz
force-pushed
the
fix/dark-theme-stories-2
branch
from
d79a3f6 to
514294f
Compare
Adzouz
force-pushed
the
fix/dark-theme-stories-2
branch
from
514294f to
86cf734
Compare
Adzouz
force-pushed
the
fix/dark-theme-stories-2
branch
from
323dc38 to
29a878b
Compare
Adzouz
force-pushed
the
fix/dark-theme-stories-2
branch
from
2cf933d to
78d5e54
Compare
Adzouz
force-pushed
the
fix/dark-theme-stories-2
branch
from
bcc06fd to
7af1faf
Compare
Adzouz
force-pushed
the
fix/dark-theme-stories-2
branch
from
7af1faf to
7c89efe
Compare
Adzouz
force-pushed
the
fix/dark-theme-stories-2
branch
from
d632091 to
a26cd13
Compare
Adzouz
force-pushed
the
fix/dark-theme-stories-2
branch
from
fe2eaf4 to
08aea86
Compare
Adzouz
force-pushed
the
fix/dark-theme-stories-2
branch
from
08aea86 to
a01258a
Compare
jhoward1994
reviewed
Aug 7, 2025
| // For docs, check localStorage directly | ||
| return localStorage.getItem('sb-addon-themes-3') === 'dark'; | ||
|
|
||
| const themeParameters = localStorage.getItem('sb-addon-themes-3'); |
There was a problem hiding this comment.
Could we extract this 'sb-addon-themes-3' to const somewhere ??
There was a problem hiding this comment.
The thing is that we need to extract it at launch for this useState but also everytime again in the useEffect so by making it more global, its value won't change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Second PR (without updating ESlint dependencies and fixing code errors raised by the bump of eslint version)
Fix the dark mode support in the stories and the Color page that was broken since last update of the Design System.
Why is it needed?
After bumping to the latest version of dependencies (storybook v9 and using @vueless/storybook-dark-mode), the dark mode switch in Storybook wasn't working anymore.
In addition, it was breaking the Foundation > Color page because it was using a hook that is not allowed in the stories components.
How to test it?
-> The page should display the list of colors correctly without any error
🚀