-
Notifications
You must be signed in to change notification settings - Fork 192
feat: Badge Variants #1967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Badge Variants #1967
Conversation
🦋 Changeset detectedLatest commit: 19008c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@HoldenFolk is attempting to deploy a commit to the Strapi Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your help @HoldenFolk, I've put few comments about the current default badge colors
Thanks for the review and changes @HichamELBSI. Appreciate the guidance! |
224742c
to
453db09
Compare
Please squash your commits so we can move on with this PR. |
453db09
to
c7afa40
Compare
c7afa40
to
19008c2
Compare
|
What does it do?
variant
prop to the Badge component. Can control badge colors with default variantsWhy is it needed?
To create stricter configuration of the Badge component for users, and allow us to deprecate the status component.
How to test it?
Provide information about the environment and the path to verify the behaviour.
Related issue(s)/PR(s)
Issue #1935