Refactor SemanticEval to receive only one SemanticStore #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomb
reviewed
Nov 17, 2025
Contributor
atomb
left a comment
atomb
left a comment
There was a problem hiding this comment.
Even though this adds a couple of sorrys, I'm inclined perhaps to go ahead with merging it and fixing those in a separate PR, since the refactoring this does will conflict with quite a few potential changes and will also make working with the semantics easier in general, whereas the work on fixing the proofs is essentially independent of anything else.
aqjune-aws
requested review from
MikaelMayer,
andrewmwells-amazon and
shigoel
as code owners
Contributor
Author
|
Ok..! Changed the status of PR to ready. :) |
atomb
previously approved these changes
Nov 17, 2025
Contributor
atomb
left a comment
atomb
left a comment
There was a problem hiding this comment.
Could you update the main PR description before merging?
aqjune-aws
force-pushed
the
jlee/semanticeval-onestoreinput
branch
from
dc3a21c to
e0af0d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This pull request updates the expression evaluator (
SemanticEvalin Strata) which previously needed to take two states: one for old expressions, one for normal (‘new’) expressions, but after this pull request it takes only one state.It introduces a couple of
sorrys, but these will be eventually fixed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.