add option to use targetPortName in create service port function #11510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
im-konge
reviewed
Jun 19, 2025
Member
im-konge
left a comment
im-konge
left a comment
There was a problem hiding this comment.
Thanks for the PR, I checked the code and have one comment.
cluster-operator/src/main/java/io/strimzi/operator/cluster/model/ServiceUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: AvivGuiser <[email protected]>
im-konge
approved these changes
Jun 24, 2025
scholzj
reviewed
Jun 24, 2025
cluster-operator/src/main/java/io/strimzi/operator/cluster/model/ServiceUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Member
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
@katheris do you have something to this? Or we can merge it? |
see-quick
pushed a commit
to see-quick/strimzi-kafka-operator
that referenced
this pull request
Sep 4, 2025
…imzi#11510) Signed-off-by: AvivGuiser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Select the type of your PR
Description
this PR add the option and moved services to use named ports instead of plain port numbers
fixes #11393
Checklist
Please go through this checklist and make sure all applicable tasks have been done