-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add documentation for tracking progress of Cruise Control rebalances. #11529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PaulRMellor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Thanks, Kyle.
I made a few suggestions.
Suggestions on intro to provide a bit more context on the procedure and what's used in tracking
documentation/assemblies/cruise-control/assembly-cruise-control-concepts.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/cruise-control/proc-tracking-cluster-rebalance.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/cruise-control/proc-tracking-cluster-rebalance.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/cruise-control/proc-tracking-cluster-rebalance.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/cruise-control/proc-tracking-cluster-rebalance.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/cruise-control/proc-tracking-cluster-rebalance.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Kyle Liberti <[email protected]>
5d810a9 to
634df7b
Compare
|
@PaulRMellor Thanks for the review, I have just applied you suggestions. |
|
@kyguy I see the PR is still in draft, or others can review it? |
|
@ppatierno reviews are welcome! Just moved out of "Draft" mode now. |
|
@PaulRMellor Does this look good to you now? Thanks. |
documentation/modules/cruise-control/proc-tracking-cluster-rebalance.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Kyle Liberti <[email protected]>
documentation/modules/cruise-control/proc-tracking-cluster-rebalance.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/cruise-control/proc-tracking-cluster-rebalance.adoc
Show resolved
Hide resolved
Signed-off-by: Kyle Liberti <[email protected]>
ppatierno
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for addressing the comments @kyguy
…strimzi#11529) Signed-off-by: Kyle Liberti <[email protected]>
Type of change
Description
Documents how to monitor the progression of an ongoing partition rebalance leveraging the new KafkaRebalance tracking feature #11348 using the Kubernetes CLI as described by the proposal here [1].
[1] https://github.com/strimzi/proposals/blob/main/098-rebalance-progress-status.md#accessing-progress-fields-using-kubernetes-cli
Checklist
Please go through this checklist and make sure all applicable tasks have been done