-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Docs integreate strimzi metrics reporter kc mm2 #11575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs integreate strimzi metrics reporter kc mm2 #11575
Conversation
6629638 to
9ae03f5
Compare
| ├── strimzi-metrics-reporter | ||
| | ├── grafana-dashboards <10> | ||
| | | ├── strimzi-kafka.json | ||
| | | ├── strimzi-kafka.json| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| | | ├── strimzi-kafka.json| | |
| | | ├── strimzi-kafka.json |
PaulRMellor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Owen. Looks good.
You asked about whether to include example config for Connect/MM2 in 25.2.2. Enabling Strimzi Metrics Reporter.
I don't think so. The config is the same.
| <11> Resource for deploying and configuring Strimzi Metrics Reporter based KafkaConnect. | ||
| <12> Resource for deploying and configuring Strimzi Metrics Reporter based MirrorMaker2. | ||
| <13> Resource for deploying and configuring Strimzi Metrics Reporter based Kafka. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <11> Resource for deploying and configuring Strimzi Metrics Reporter based KafkaConnect. | |
| <12> Resource for deploying and configuring Strimzi Metrics Reporter based MirrorMaker2. | |
| <13> Resource for deploying and configuring Strimzi Metrics Reporter based Kafka. | |
| <11> `KafkaConnect` resource for deploying Kafka Connect with Strimzi Metrics Reporter. | |
| <12> `KafkaMirrorMaker2` resource for deploying MirrorMaker 2 with Strimzi Metrics Reporter. | |
| <13> `Kafka` resource for deploying Kafka with Strimzi Metrics Reporter. |
| * `kafka-metrics.yaml` | ||
| * `kafka-connect-metrics.yaml` | ||
| * `kafka-mirror-maker-2-metrics.yaml` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it help to put the containing folder here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @PaulRMellor. I don't quite get you. Do you mean add the containing examples folder to the PR or something else? The updated folder will be part of the integration PR which will be merged before this I reckon.
This is the structure that the folder will take:
├── strimzi-metrics-reporter
| ├── grafana-dashboards (10)
| | ├── strimzi-kafka.json
| | ├── strimzi-kafka-connect.json
| | ├── strimzi-kafka-mirror-maker-2.json
| | ├── strimzi-kraft.json
│ ├── kafka-connect-metrics.yaml (11)
│ ├── kafka-metrics.yaml (12)
| └── kafka-mirror-maker-2-metrics.yaml (13)
Thanks
|
@OwenCorrigan76 is this ready to be reviewed? Now that KC and MM2 integration is merged, it would be good to also get this one. |
|
I have another commit that I will push shortly. Then it can be reviewd. Thanks @fvaleri |
d243797 to
5dc84a6
Compare
This patch adds trimzi Metrics Reporter integration with KC and MM2. Signed-off-by: OwenCorrigan76 <[email protected]>
Signed-off-by: Federico Valeri <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>
Signed-off-by: Federico Valeri <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>
Signed-off-by: Federico Valeri <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>
Signed-off-by: OwenCorrigan76 <[email protected]>
Signed-off-by: Federico Valeri <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>
Signed-off-by: Federico Valeri <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>
Signed-off-by: OwenCorrigan76 <[email protected]>
Signed-off-by: Federico Valeri <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>
Signed-off-by: Federico Valeri <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>
Signed-off-by: Federico Valeri <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>
Signed-off-by: Federico Valeri <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>
Signed-off-by: OwenCorrigan76 <[email protected]>
5dc84a6 to
5fe2d59
Compare
fvaleri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
|
@scholzj now that related feature is merged, can you also have another look at this one? |
Signed-off-by: OwenCorrigan76 <[email protected]> Signed-off-by: Federico Valeri <[email protected]>
Type of change
Description
With newly added support for the Strimzi Metrics Reporter to KafkaConnect and MirrorMaker2, this PR updates the assemblies and modules documents to reflect the changes in the way we can deploy metrics to the KafkaConnect and MirrorMaker2.
Updates:
Structure for new content:
Related to #11051
Checklist
Please go through this checklist and make sure all applicable tasks have been done