Skip to content

Conversation

anki2189
Copy link
Member

@anki2189 anki2189 commented Apr 26, 2020

This pull request closes strongbox/strongbox#1755

@anki2189 anki2189 changed the base branch from master to issues/1649 April 26, 2020 13:09
@anki2189
Copy link
Member Author

@sbespalov Pls review the changes.

Copy link
Member

@sbespalov sbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anki2189 many thanks for the PR!
could you please proceed with few comments here?

@anki2189
Copy link
Member Author

Build is passing all the tests strongbox/strongbox#1758.

@sbespalov sbespalov merged commit 4ff9562 into strongbox:issues/1649 Apr 27, 2020
@sbespalov
Copy link
Member

merged!
thanks @anki2189 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants