-
Notifications
You must be signed in to change notification settings - Fork 9
Updates #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Mike-W00d
wants to merge
4
commits into
sturents:master
Choose a base branch
from
Mike-W00d:updates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Updates #23
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7f608d4
Adding viewing URL to properties outbound, fixing price outbound type…
Mike-W00d 900e67f
Updated api.yml and ran generate to fix changes
Mike-W00d abc4fe0
More Api documentation updates
Mike-W00d 59ce076
Merge branch 'sturents:master' into updates
Mike-W00d File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,7 +20,7 @@ class Price extends SwaggerModel | |
| * will be used to calculate total and scheduled payments when | ||
| * creating a tenancy and/or rent collection for the property. | ||
| * | ||
| * @var float | ||
| * @var string | ||
| * @required | ||
| */ | ||
| protected $price_per_person_per_week; | ||
|
|
@@ -29,9 +29,9 @@ class Price extends SwaggerModel | |
| * A monetary value indicating the deposit each tenant will be | ||
| * expected to pay upon signing a contract to rent the property | ||
| * | ||
| * @var float | ||
| * @var string | ||
| */ | ||
| protected $deposit_per_person = 0.0; | ||
| protected $deposit_per_person = ''; | ||
|
|
||
| /** | ||
| * A monetary value indicating the fee to the property manager which | ||
|
|
@@ -40,11 +40,11 @@ class Price extends SwaggerModel | |
| * | ||
| * @var float | ||
| */ | ||
| protected $fee_per_person = 0.0; | ||
| protected $fee_per_person; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we want to remove this default? |
||
|
|
||
|
|
||
| /** | ||
| * @return float | ||
| * @return string | ||
| */ | ||
| public function getPricePerPersonPerWeek() | ||
| { | ||
|
|
@@ -53,7 +53,7 @@ public function getPricePerPersonPerWeek() | |
|
|
||
|
|
||
| /** | ||
| * @param float $price_per_person_per_week | ||
| * @param string $price_per_person_per_week | ||
| * | ||
| * @return $this | ||
| */ | ||
|
|
@@ -66,7 +66,7 @@ public function setPricePerPersonPerWeek($price_per_person_per_week) | |
|
|
||
|
|
||
| /** | ||
| * @return float | ||
| * @return string | ||
| */ | ||
| public function getDepositPerPerson() | ||
| { | ||
|
|
@@ -75,7 +75,7 @@ public function getDepositPerPerson() | |
|
|
||
|
|
||
| /** | ||
| * @param float $deposit_per_person | ||
| * @param string $deposit_per_person | ||
| * | ||
| * @return $this | ||
| */ | ||
|
|
@@ -101,7 +101,7 @@ public function getFeePerPerson() | |
| * | ||
| * @return $this | ||
| */ | ||
| public function setFeePerPerson($fee_per_person) | ||
| public function setFeePerPerson(float $fee_per_person) | ||
| { | ||
| $this->fee_per_person = $fee_per_person; | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be '0.0' (as a string) to keep default the same while typing correctly?