Skip to content

✨(frontend) use title first emoji as doc icon in tree #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

olaurendeau
Copy link
Contributor

@olaurendeau olaurendeau commented Aug 15, 2025

Purpose

This pull request intent to fix this issue.
If the first unicode char of a title is an emoji, this emoji will replace the standard icon in the tree.

Screenshot 2025-08-15 at 16 07 30

Proposal

I have made use of the library emoji-regex, because I didn't find a solution simple enough with a regex which would be compatible with ES5.

I took the liberty to add a make frontend-test command.

E2E Frontend test are failing, not sure it relates to this PR. I also had to increase the GitHub Action timeout so that it complete.

External contributions

Please ensure the following items are checked before submitting your pull request:

  • I have read and followed the contributing guidelines
  • I have read and agreed to the Code of Conduct
  • I have signed off my commits with git commit --signoff (DCO compliance)
  • I have signed my commits with my SSH or GPG key (git commit -S)
  • My commit messages follow the required format: <gitmoji>(type) title description
  • I have added a changelog entry under ## [Unreleased] section (if noticeable change)
  • I have added corresponding tests for new features or bug fixes (if applicable)

@olaurendeau olaurendeau force-pushed the feat/emoji-in-tree branch 2 times, most recently from 5297aae to f437f27 Compare August 15, 2025 14:21
Implemented emoji detection system, new DocIcon component.
It was failing at 20min, increase the timeout to 30 min
@virgile-dev virgile-dev requested review from Ovgodd and AntoLC August 19, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transform the basic page icon by the emoji of the title in the tree structure
1 participant