-
Notifications
You must be signed in to change notification settings - Fork 380
✨(frontend) add pdf block to the editor #795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: dakshesh14 <[email protected]>
Signed-off-by: dakshesh14 <[email protected]>
Signed-off-by: dakshesh14 <[email protected]>
Signed-off-by: dakshesh14 <[email protected]>
Signed-off-by: dakshesh14 <[email protected]>
Hey team, this is my first PR in the repo, and I <3 the project! I think there are a couple of areas that we could be improved in my PR and, I would love the maintainers' input on:
Please let me know if I should look into these or if there are any other comments or suggestions. Once again, I love the project! |
Hi, thank you for this nice PR! |
Hi @AntoLC, I just wanted to follow up on this PR. I'd really appreciate your feedback on the implementation. Once I have your review, I’ll go ahead and resolve the merge conflicts and update the changelog as well. Thanks! |
Closing due to lack of response. |
Hey @dakshesh14 |
Hi @virgile-dev, I appreciate the response. I totally understand how things can get packed with events. I'm glad to hear the team is back and planning to improve the contributor experience. I’d be happy to reopen the PR and continue contributing to the project. I really like the direction you’re taking and think there’s a lot I can learn here, while also giving back in a meaningful way. I’ve been a contributor to Plane and Huly, and would love to get more involved in this project too. Before I dive back in, I just wanted to check a couple of things so I’m aligned with the project’s goals:
Really appreciate the kind words on the PDF block idea, and I’m excited to build on it once I’ve got a clearer picture. |
Hey @dakshesh14
|
Hi @virgile-dev, Thanks for the clarification — that makes sense, and I really appreciate the openness. I'm definitely excited to contribute further and be a part of Docs. Since I no longer have my fork, I’ll need to rework this PR and raise a new one. I’ll also try to contribute more across the repo going forward. Cheers |
Hi @virgile-dev, I’ve created a new PR here: #1293 since I lost my fork and couldn’t reopen this one. Looking forward to the team’s feedback and review! Cheers, |
Purpose
Added an option for users to upload and preview PDF files in the editor. This PR addresses #348.
feat-pdf-upload.mov
Proposal
Added the option for users to upload and preview PDF files within the editor.
Description: