Skip to content

✨(frontend) add pdf block to the editor #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

dakshesh14
Copy link

Purpose

Added an option for users to upload and preview PDF files in the editor. This PR addresses #348.

feat-pdf-upload.mov

Proposal

Added the option for users to upload and preview PDF files within the editor.

Description:

  • When a user types '/' on their keyboard, they can find an option called "PDF," which allows them to upload or embed PDF files.
  • A fallback is provided for browsers that do not support the 'embed' tag.

@dakshesh14
Copy link
Author

Hey team, this is my first PR in the repo, and I <3 the project! I think there are a couple of areas that we could be improved in my PR and, I would love the maintainers' input on:

  1. Using react-pdf or another library for better PDF preview compatibility and UX.
  2. Changing the nginx config might not be acceptable, so I’m open to discussing alternatives.

Please let me know if I should look into these or if there are any other comments or suggestions. Once again, I love the project!

@lunika lunika requested review from AntoLC and lunika March 23, 2025 18:15
@AntoLC
Copy link
Collaborator

AntoLC commented Mar 24, 2025

Hi, thank you for this nice PR!
I will catch some time this week to look at it correctly.

@dakshesh14
Copy link
Author

Hi @AntoLC,

I just wanted to follow up on this PR. I'd really appreciate your feedback on the implementation. Once I have your review, I’ll go ahead and resolve the merge conflicts and update the changelog as well.

Thanks!

@dakshesh14
Copy link
Author

Closing due to lack of response.

@dakshesh14 dakshesh14 closed this May 27, 2025
@dakshesh14 dakshesh14 deleted the feat/pdf-upload branch May 27, 2025 17:39
@virgile-dev
Copy link
Collaborator

Hey @dakshesh14
So sorry we weren't responsive on this PR.
We've been swamped with a bunch of time consuming task (security homologation, organizing the HackDays and attending a bunch of other events).
In the the coming months we're hoping to provide a better contributing experience.
We're pretty excited by your PDF block idea. Thanks for taking the time to submit it. @YousefED you should take a look it's cool !
My feedback from a product perspective is that we should probably allow users to resize the PDF viewer.
Let me know if you'd like to finish it. I'll make sure the team has time to review it.
Cheers

@dakshesh14
Copy link
Author

Hi @virgile-dev,

I appreciate the response. I totally understand how things can get packed with events. I'm glad to hear the team is back and planning to improve the contributor experience.

I’d be happy to reopen the PR and continue contributing to the project. I really like the direction you’re taking and think there’s a lot I can learn here, while also giving back in a meaningful way. I’ve been a contributor to Plane and Huly, and would love to get more involved in this project too.

Before I dive back in, I just wanted to check a couple of things so I’m aligned with the project’s goals:

  1. Are community contributions actively welcomed and reviewed long-term? I want to make sure this is something the team is open to growing with.
  2. I noticed issue #833 and some mention of “European open-source.” Could you clarify what that means in practice? I’m here to contribute to open-source in the broader sense, so just want to make sure I'm on the same page.

Really appreciate the kind words on the PDF block idea, and I’m excited to build on it once I’ve got a clearer picture.

@virgile-dev
Copy link
Collaborator

Hey @dakshesh14
Thanks for answering !

  1. Yes ! We're hoping to build a strong community around Docs.
  2. We organized the Hack Days a few weeks ago and gathered ~ 250 hackers from 17 countries. Among them Brazil, Canada, Japan and more. Open source doesn't stop at Europe's border neither does digital autonomy. We're hoping to lead a European effort as the project was intiated by the French and German government but are open to welcome contributors from around the world.

@dakshesh14
Copy link
Author

Hi @virgile-dev,

Thanks for the clarification — that makes sense, and I really appreciate the openness. I'm definitely excited to contribute further and be a part of Docs.

Since I no longer have my fork, I’ll need to rework this PR and raise a new one. I’ll also try to contribute more across the repo going forward.

Cheers

@dakshesh14
Copy link
Author

Hi @virgile-dev,

I’ve created a new PR here: #1293 since I lost my fork and couldn’t reopen this one.

Looking forward to the team’s feedback and review!

Cheers,
Dakshesh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants