✨(front) Allow to pick files from drive if set up. #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbpenrath
force-pushed
the
feat/drive-interop
branch
3 times, most recently
from
1533243 to
a1c3b8e
Compare
jbpenrath
force-pushed
the
feat/drive-interop
branch
from
a1c3b8e to
670231c
Compare
jbpenrath
force-pushed
the
feat/drive-interop
branch
from
670231c to
e592d15
Compare
Only allow to upload blob of 25MB as attachment
jbpenrath
force-pushed
the
feat/drive-interop
branch
from
e592d15 to
aeedea0
Compare
jbpenrath
changed the title
jbpenrath
force-pushed
the
feat/drive-interop
branch
from
aeedea0 to
d36c233
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements drive file attachment functionality by allowing users to pick and attach files from an external Drive service when configured. It includes comprehensive support for serializing, extracting, and displaying drive attachments throughout the mail workflow.
- Adds a feature flag system for toggling external service integrations including Drive
- Implements complete drive attachment handling in drafts, text bodies, and HTML bodies with extraction utilities
- Integrates a Drive file picker component with the message form's attachment uploader
Reviewed Changes
Copilot reviewed 28 out of 29 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
src/frontend/src/hooks/use-feature.ts |
New feature flag system to manage external service availability |
src/frontend/src/features/utils/mail-helper.tsx |
Core utilities for serializing/extracting drive attachments in different formats |
src/frontend/src/features/forms/components/message-form/drive-attachment-picker.tsx |
Drive file picker component using external SDK |
src/frontend/src/features/forms/components/message-form/attachment-uploader.tsx |
Enhanced attachment uploader supporting both local and drive files |
src/frontend/src/features/layouts/components/thread-view/components/thread-message/index.tsx |
Thread message view updated to display drive attachments |
src/backend/core/api/viewsets/config.py |
Backend configuration endpoint extended to include Drive service URLs |
Files not reviewed (1)
- src/frontend/package-lock.json: Language not supported
...eatures/layouts/components/thread-view/components/thread-attachment-list/attachment-item.tsx
Outdated
Show resolved
Hide resolved
src/frontend/src/features/forms/components/message-form/index.tsx
Outdated
Show resolved
Hide resolved
We want to add ability to Messages to interop with our Drive application. First, we want to be able to set the Drive base url through environment variable then pass down Drive configuration to frontend through the config api endpoint. https://github.com/suitenumerique/drive
Add a hook to know if a feature is enabled or not (AI Features, Interop Features, etc.)
jbpenrath
force-pushed
the
feat/drive-interop
branch
from
d36c233 to
0153e35
Compare
Use the drive-sdk package to allow user to pick a file from its drive workspace if one drive instance has been set up through envvars. https://github.com/suitenumerique/drive
jbpenrath
force-pushed
the
feat/drive-interop
branch
from
0153e35 to
e7758c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
#Hackdays2025