Selfcheck prometheus #319
Merged
Selfcheck prometheus #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvinus
reviewed
Aug 20, 2025
sylvinus
reviewed
Aug 20, 2025
|
LGTM, I imagine we'll refactor this if we have many more prom integrations elsewhere in Messages but OK as a first step! |
for better grepability
Definitely, although this one is a bit special as it's pushing in a PushGateway and not exposing metrics as we'll do in the backend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add prometheus metrics that get pushed to a Prometheus pushgateway on success.
Proposal
By default, the script uses the
SelfCheckMetricsBaseclass as its metrics collector, that does not do anything on start, stop, etc.If the Prometheus env variables are defined, the metrics collector will use
SelfCheckPrometheusMetricsthat extendsSelfCheckMetricsBaseand will update its metrics and push them to the pushgateway on exit.This allows users to extend the MetricsBase class to integrate their own system, as well as having a single
ifclause that does not render the rest of the code unreadable.