-
-
Notifications
You must be signed in to change notification settings - Fork 4
Implement Native Google OAuth for Apple targets #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added instructions for integrating GoogleSignIn.
|
Tested in my personal project. Working fine. Kudos.Snap.iOS.Google.Native.OAuth.mp4 |
|
Hey @jan-tennert , is it possible to publish a test artifact of this version of the lib so that I can test it end to end? |
|
@hieuwu This should work: //repo
maven("https://central.sonatype.com/repository/maven-snapshots/")implementation("io.github.jan-tennert.supabase:compose-auth:3.2.7-SNAPSHOT") |
Tested following guideline in this update at supabase-community/supabase-kt#1093 . |
ComposeAuth/src/appleMain/kotlin/io/github/jan/supabase/compose/auth/composable/GoogleAuth.kt
Outdated
Show resolved
Hide resolved
ComposeAuth/src/appleMain/kotlin/io/github/jan/supabase/compose/auth/composable/GoogleAuth.kt
Outdated
Show resolved
Hide resolved
ComposeAuth/src/swift/nativeBridge/GoogleSignInController.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comment on the debug logs, didn't comment all of them but all of them could be a little bit more expressive, doesn't have to be the suggestions 1:1
ComposeAuth/src/appleMain/kotlin/io/github/jan/supabase/compose/auth/composable/GoogleAuth.kt
Outdated
Show resolved
Hide resolved
ComposeAuth/src/appleMain/kotlin/io/github/jan/supabase/compose/auth/composable/GoogleAuth.kt
Outdated
Show resolved
Hide resolved
ComposeAuth/src/appleMain/kotlin/io/github/jan/supabase/compose/auth/composable/GoogleAuth.kt
Outdated
Show resolved
Hide resolved
ComposeAuth/src/appleMain/kotlin/io/github/jan/supabase/compose/auth/composable/GoogleAuth.kt
Outdated
Show resolved
Hide resolved
|
publishhh |
I'll try to finish up the new version today, otherwise on the weekend |
What kind of change does this PR introduce?
Native Google Oauth for iOS target with GoogleSignIn by using Swift in Kotlin with cinterop. SPM for deps management with
spm4kmpWhat is the current behavior?
Currently only support OAuth fallback with browser
What is the new behavior?
Support Native Google OAuth with GoogleSignIn iOS. If fails, fallback to browser
How to set up:
XCode: 26
Google Console
Supabase Dashboard
Feel free to include screenshots if it includes visual changes.
Additional context
Native.Google.OAuth.iOS.mp4
Issues might face:
openid/AppAuth-iOS#123
frankois944/spm4Kmp#206