fix: rate limit presence events #1493
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
filipecabaco
force-pushed
the
fix/rate-limit-presence-events
branch
from
786f7ef to
e23258e
Compare
filipecabaco
force-pushed
the
fix/rate-limit-presence-events
branch
from
73957f4 to
fb7cda7
Compare
filipecabaco
force-pushed
the
fix/rate-limit-presence-events
branch
7 times, most recently
from
f1d7589 to
a0ece8d
Compare
| @@ -706,7 +706,6 @@ defmodule Realtime.Integration.RtChannelTest do | |||
|
|
|||
| WebsocketClient.send_event(socket, topic, "presence", payload) | |||
|
|
|||
| assert_receive %Phoenix.Socket.Message{topic: ^topic, event: "phx_reply", payload: %{"status" => "ok"}} | |||
There was a problem hiding this comment.
Do you know why this has changed?
There was a problem hiding this comment.
this should not be here as this could be an error actually as this event would mean it reconnected 👀
filipecabaco
force-pushed
the
fix/rate-limit-presence-events
branch
from
4f1ce27 to
49402ce
Compare
filipecabaco
force-pushed
the
fix/rate-limit-presence-events
branch
from
49402ce to
f923e1d
Compare
| ) do | ||
| %{assigns: %{authorization_context: authorization_context}} = socket | ||
| defp handle_presence_event("track", payload, db_conn, socket) | ||
| when can_write_presence?(socket) and is_nil(socket.assigns.policies.presence.write) do |
There was a problem hiding this comment.
nit: Maybe here it could be only when is_nil(socket.assigns.policies.presence.write) which means we still need to calculate just for this case?
There was a problem hiding this comment.
did this change as it also simplifies a lot the guard of the function
| push(socket, "presence_state", presence_dirty_list(topic)) | ||
| {:noreply, socket} | ||
| @spec sync(Socket.t()) :: | ||
| :ok | {:error, :rls_policy_error | :unable_to_set_policies | :rate_limit_exceeded} |
There was a problem hiding this comment.
can this function return rls_policy_error or unable_to_set_policies?
There was a problem hiding this comment.
no! copy pasta strikes again
|
🎉 This PR is included in version 2.42.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What kind of change does this PR introduce?
rate limit presence events