-
-
Notifications
You must be signed in to change notification settings - Fork 226
feat: add support for sorting in list v2 endpoint #749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 17679481788Details
💛 - Coveralls |
24b869c
to
251558f
Compare
251558f
to
e7ec3a0
Compare
e7ec3a0
to
c7d468f
Compare
c7d468f
to
542373e
Compare
src/storage/database/knex.ts
Outdated
@@ -269,27 +269,55 @@ export class StorageKnexDB implements Database { | |||
nextToken?: string | |||
maxKeys?: number | |||
startAfter?: string | |||
sortOrder?: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding the order in the sortBy
object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. I originally had it outside because it sorts by name even if sortBy is undefined so this allowed setting asc/desc without including the sortBy
object, but having it all grouped together probably makes more sense.
What kind of change does this PR introduce?
Feature
What is the current behavior?
The list v2 endpoint does not support sorting like the old list endpoint
What is the new behavior?