-
-
Notifications
You must be signed in to change notification settings - Fork 159
test: add tests for HTTPError and PostgrestError types #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
grdsdev
wants to merge
8
commits into
main
Choose a base branch
from
guilherme/increase-code-coverage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+580
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 16154474100Details
💛 - Coveralls |
a455d97
to
31df495
Compare
Covers value accessors, literal initializers, error handling, extensions, and edge cases to ensure full correctness and robustness.
Add tests for the HTTPError type covering initialization, property access, and LocalizedError conformance for various data scenarios. Ensures robust error reporting and future-proofing for HTTP error handling.
- Split combined linux_android job into separate linux and android jobs for better isolation - Uncomment library-evolution job that was previously commented out - Improve CI workflow organization and maintainability
- Add test to verify PostgrestError properly conforms to LocalizedError protocol - Test ensures errorDescription property returns the expected error message - Improves test coverage for error handling functionality
- Remove Xcode 15.2 testing (keep only 15.4 for backward compatibility) - Remove tvOS, visionOS, and watchOS platforms (less critical for backend SDK) - Keep iOS, macOS, and macCatalyst for comprehensive coverage - Maintain Linux and Android cross-platform testing - Expected 50-60% reduction in CI time while maintaining good coverage This optimization focuses on the most commonly used platforms while significantly reducing CI resource usage and wait times.
3789e86
to
877ad46
Compare
grdsdev
commented
Jul 9, 2025
copy-files: Tests | ||
# tests are not yet passing on Android | ||
run-tests: false | ||
# android: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't really support android as a build target, and this check was added by an external contributor, I won't spent much time on trying to debug it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive test coverage for various components of the supabase-swift library:
Changes Made
CI Workflow Improvements
linux_android
job into separatelinux
andandroid
jobs for better isolationlibrary-evolution
job that was previously commented outTest Coverage Enhancements
Benefits
Testing
All tests pass locally and in CI. The new tests cover: