feat: allow updating a project's instance size #255
+241
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savme
force-pushed
the
alex/ter-7-allow-users-to-upgrade-their-compute-size-after-project
branch
from
6719d52 to
b2b3093
Compare
savme
force-pushed
the
alex/ter-7-allow-users-to-upgrade-their-compute-size-after-project
branch
from
b2b3093 to
f9459b5
Compare
| // Read Terraform plan data into the model | ||
| resp.Diagnostics.Append(req.Plan.Get(ctx, &data)...) | ||
| resp.Diagnostics.Append(req.Plan.Get(ctx, &plan)...) | ||
| resp.Diagnostics.Append(req.State.Get(ctx, &state)...) |
Collaborator
There was a problem hiding this comment.
Can we ignore values in the current state? I believe TF client will handle this comparison.
| return diag.Diagnostics{diag.NewErrorDiagnostic("Client Error", msg)} | ||
| } | ||
|
|
||
| if addonsResp.JSON200 != nil { |
Collaborator
There was a problem hiding this comment.
Let's bubble up errors here
| var freeInstanceSizes = []string{ | ||
| string(api.V1CreateProjectBodyDesiredInstanceSizeNano), | ||
| string(api.V1CreateProjectBodyDesiredInstanceSizePico), | ||
| } |
Collaborator
There was a problem hiding this comment.
Moving this check to api side
Collaborator
There was a problem hiding this comment.
On closer look, we need to call the api to remove compute addon if user specifies nano or pico compute size. https://api.supabase.com/api/v1#tag/billing/delete/v1projectsrefbillingaddonsaddon_variant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
What is the current behavior?
Changing
instance_sizeis not supported.Attempting to do so results in the following error:
Update is not supported for project resource: <project>What is the new behavior?
Plans like this are supported