Jphenow/deployer mergeable #4654
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y deploy with everything from the manifest
…k during the plan step
Note: no longer abort processing if bundle install fails
Fixed two bugs in the updateConfig CPU/Memory override loops: 1. Changed from value-based to index-based iteration - Before: for _, c := range (modifies copies, changes lost) - After: for i := range (modifies actual slice elements) 2. Added defensive conditionals to only set empty values - Prevents conflicts with updateComputeFromDeprecatedGuestFields - Only fills in missing CPUKind/CPUs/MemoryMB values This maintains the compatibility layer for plan-level compute overrides while avoiding the bugs that were causing preflight test failures. Fixes preflight test failures in indices 7, 8, 13. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
The Compute struct has an embedded *fly.MachineGuest pointer, and the fields CPUKind, CPUs, and MemoryMB are on that embedded pointer. The recent commit 3817455 fixed the index-based iteration but was still missing the check for MachineGuest != nil. Without this check, the code panics with a nil pointer dereference when trying to access these fields on a nil MachineGuest pointer. Fixes TestLaunchCpusMem and other related test failures.
lubien
reviewed
Nov 18, 2025
| @@ -1,26 +1,43 @@ | |||
| package scanner | |||
|
|
|||
| import ( | |||
Member
There was a problem hiding this comment.
idk, felt out of place but I might be wrong
Member
Author
There was a problem hiding this comment.
lubien
approved these changes
Nov 18, 2025
All plan command functions (runPropose, runCreate, runPostgres, runRedis, runTigris) were ignoring errors returned from RunPlan(), causing commands to exit with status 0 even when they failed. This caused silent failures where flyctl would fail (e.g., authorization errors) but exit successfully, making debugging extremely difficult. Fixed by properly returning errors from RunPlan() in all plan command functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP