Skip to content

Conversation

@jycouet
Copy link
Contributor

@jycouet jycouet commented Dec 6, 2025

  • moved folders with git mv ... to preserve git history (please pull and check!)

Gist of the PR

  • packages/cli -> packages/sv
  • packages/core -> packages/sv/lib/core
  • packages/create -> packages/sv/lib/create
  • packages/addons -> packages/sv/lib/addons
  • packages/cli/commands -> packages/sv/lib/cli

Preparing work for community ;)

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2025

⚠️ No Changeset found

Latest commit: e98e09b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jycouet jycouet marked this pull request as draft December 6, 2025 21:58
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 6, 2025

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@838
npx https://pkg.pr.new/sveltejs/cli/sv@838

commit: e98e09b

@jycouet jycouet marked this pull request as ready for review December 6, 2025 23:35
Copy link
Member

@manuel3108 manuel3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the diff, a few tests got deleted. Any reason why?

Image

Ohhhh, they are re-added in another place. Probably just git fucking around with so many files.

Deleted the change set, as this is not "customer facing" and only internal, similar to the other PRs we merged.

Cool that you managed to keep the testing setup for pnpm test --project core and so on. In the future we could thing about extracting all of the long running "create" and "addon" tests into a seperate package or something, so that you could just run "pnpm test" in the sv directory again. But we can bother about that at a later point.

Also some of these imports became really long, we could consider a path alias or something.

But apart from that, I did not see anything that is not working, so merging this to get it out of the way.

Thanks 🥳

@manuel3108 manuel3108 merged commit 0b25394 into main Dec 7, 2025
8 checks passed
@manuel3108 manuel3108 deleted the feat/restructure-project branch December 7, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants