-
-
Notifications
You must be signed in to change notification settings - Fork 70
chore: update project structure #838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
commit: |
manuel3108
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the diff, a few tests got deleted. Any reason why?
Ohhhh, they are re-added in another place. Probably just git fucking around with so many files.
Deleted the change set, as this is not "customer facing" and only internal, similar to the other PRs we merged.
Cool that you managed to keep the testing setup for pnpm test --project core and so on. In the future we could thing about extracting all of the long running "create" and "addon" tests into a seperate package or something, so that you could just run "pnpm test" in the sv directory again. But we can bother about that at a later point.
Also some of these imports became really long, we could consider a path alias or something.
But apart from that, I did not see anything that is not working, so merging this to get it out of the way.
Thanks 🥳
git mv ...to preserve git history (please pull and check!)Gist of the PR
packages/cli->packages/svpackages/core->packages/sv/lib/corepackages/create->packages/sv/lib/createpackages/addons->packages/sv/lib/addonspackages/cli/commands->packages/sv/lib/cliPreparing work for
community;)