Skip to content

Conversation

@teemingc
Copy link
Member

closes #12986

This PR changes the error, isHttpError, redirect, and isRedirect functions to use the public interface version of the HttpError and Redirect errors instead of our internal classes.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@teemingc teemingc added this to the 3.0 milestone Nov 21, 2024
@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2024

🦋 Changeset detected

Latest commit: 679aba2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-13036-svelte.vercel.app/

this is an automated message

@svelte-docs-bot
Copy link

@Rich-Harris
Copy link
Member

What makes this a breaking change? (I almost merged it prematurely 😆)

@dummdidumm
Copy link
Member

My memory is hazy but I think it's mostly about changing it from a class where you can do instanceof to an interface where that would fail..?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change type of exported failure helpers from class to interface

3 participants