-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Remote Functions #13986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remote Functions #13986
Changes from 9 commits
Commits
Show all changes
153 commits
Select commit
Hold shift + click to select a range
4706f36
Remote Functions Exploration PR (#13957)
dummdidumm 47e995a
Merge branch 'main' into remote-functions
dummdidumm 91b94c0
cleanup
dummdidumm 731cbce
remove cache code for now
dummdidumm e4134ee
handleValidationError
dummdidumm 75b33a0
error property
dummdidumm b8c0026
code review
dummdidumm 902e228
tweak / simplify
dummdidumm 5e48a48
Merge branch 'main' into remote-functions
dummdidumm 351512c
merge main
Rich-Harris 5e3fc90
Apply suggestions from code review
dummdidumm 729c7a2
fix
dummdidumm 73b6f1b
fix params prop on leaf component
Rich-Harris 88d4118
refresh queries after goto with invalidateAll
dummdidumm fc90222
fix redirect logic
dummdidumm f25299b
revert overrides on error
dummdidumm fc2869b
work around Svelte bug
dummdidumm f9fa164
lint
dummdidumm 446483b
add names to error messages
dummdidumm ddecc8f
put remote function id etc assignment into helper function and add or…
dummdidumm 9b3ecb6
use cache API for prerendered functions
dummdidumm dab2946
status/isLoading property
dummdidumm 65f9dbc
add set method to resource
dummdidumm fc94477
Merge branch 'main' into remote-functions
Rich-Harris e9abf08
tweak
dummdidumm 8160907
Merge branch 'remote-functions' of https://github.com/sveltejs/kit in…
dummdidumm 95a4a92
more error message tweaks
dummdidumm d77cbb1
regenerate
dummdidumm f80a21b
use tick()
dummdidumm 46cf0c6
Update packages/kit/src/runtime/client/remote.svelte.js
Rich-Harris 9a06a92
validationerror issues tweak
dummdidumm 5a9690f
handle exotic characters when btoa encoding
dummdidumm 71b9edd
prerender tweaks
dummdidumm a54e5f3
make fn execution a method
dummdidumm dc5b01a
changeset
dummdidumm 9735f19
Update packages/kit/src/runtime/client/remote.svelte.js
Rich-Harris 6ad721b
Add RemoteCommand type (#14020)
ottomated 2e54628
Merge branch 'main' into remote-functions
dummdidumm 1fa60eb
tweaks to `remote-functions` (#14034)
Rich-Harris b9d7b85
remote functions: fix prerender types etc (#14037)
Rich-Harris 7bea158
Merge branch 'main' into remote-functions
Rich-Harris ccb11b8
remote functions: await form result (#14038)
Rich-Harris f1ba3b9
merge main
Rich-Harris 8a3c5f4
docs
dummdidumm 5c133ec
adjust docs example
dummdidumm e3bbcd6
turn RemoteQuery<Promise<Thing>> into RemoteQuery<Thing>
Rich-Harris 659a6e6
make forms non-callable (#14045)
Rich-Harris c8135f1
get rid of status, add ready
dummdidumm 590aa31
remove fail() support from remote forms
dummdidumm 62bccf7
fix types / lint
dummdidumm 44f3c63
form doc tweaks
dummdidumm 930affd
fix indentation
Rich-Harris 2d48ff3
hash once
Rich-Harris 8b2489b
make remotes project-relative
Rich-Harris 7419a67
fix
Rich-Harris d96bebc
fix
Rich-Harris fa80df4
uneval lazily
Rich-Harris 2bda0d5
don't swallow errors
Rich-Harris a12ac67
surface errors more reliably, prevent crashes
Rich-Harris 35a1239
don't clear remote_responses cache on failure. embrace the failure
Rich-Harris c5d90a5
lint
Rich-Harris 75fcfd3
simplify
Rich-Harris f57fb87
typo
Rich-Harris 0d17d3f
tweak
Rich-Harris 1d39e0a
regenerate
Rich-Harris 9611f5f
lint
Rich-Harris 94280aa
add some more explanatory comments
Rich-Harris 6cec4a8
simplify
Rich-Harris 7c3a03b
compute action/formaction lazily — this lets us initialize all remote…
Rich-Harris ebb4423
remote function init is now simple enough that we can just inline it
Rich-Harris 270392e
WIP
Rich-Harris 37ec773
WIP use existing metadata
Rich-Harris 8e7e143
no need for intermediate disk output
Rich-Harris 18225a5
unused
Rich-Harris 3eb34fd
bundle together
Rich-Harris be1d496
add explanatory comment
Rich-Harris 1ebef8c
tweak comment
Rich-Harris a1997e5
tweak
Rich-Harris 6445b39
put functions in the order they are used
Rich-Harris 2216602
debug windows nonsense
Rich-Harris 2b2f874
more debugging
Rich-Harris a576c7d
more debugging
Rich-Harris edae07d
more
Rich-Harris 86ddf27
gah
Rich-Harris 77c5718
wtaf
Rich-Harris 22789d5
come ON
Rich-Harris 9477cea
so confused
Rich-Harris 88d7608
ugh
Rich-Harris 627220c
more
Rich-Harris efafabb
howwwwwwww
Rich-Harris 0ae1421
stab in the dark
Rich-Harris 96513aa
try this
Rich-Harris fdbc1d1
fucking FINALLY
Rich-Harris 7704636
remove junk
Rich-Harris edc9095
remove outdated comment
Rich-Harris 393c1f4
tweak
Rich-Harris 8d00051
tweak naming
Rich-Harris 88f97ad
separate blocks out
Rich-Harris 539996d
call functions directly
Rich-Harris 3fe3281
tweak some names
Rich-Harris cab9619
tweaks
Rich-Harris 4eb7ae9
capitalise Bad Request
Rich-Harris eef65bf
tweaks, make cache key easier to split
Rich-Harris 576f642
tweak
Rich-Harris 2dee752
simplify
Rich-Harris 3f404a1
tweak
Rich-Harris 0340df8
make methods appear as methods rather than properties
Rich-Harris 6c9a9d1
WIP move to separate files
Rich-Harris 97ba5d9
WIP extract shared logic
Rich-Harris 95bc791
WIP more
Rich-Harris c62969a
WIP more
Rich-Harris 681f447
move remote functions into individual modules — will be easier to wor…
Rich-Harris 4bb3128
hoist
Rich-Harris d8694b9
hoist for property
Rich-Harris a02df4e
add type safety, make `entry.count` (as opposed to `entry[0]`) a reality
Rich-Harris ff2368c
simplify
Rich-Harris bbf3d94
typo
Rich-Harris 168e2e1
fix
Rich-Harris a9965a0
same on server - move functions into their own modules
Rich-Harris 6ee2778
tweak
Rich-Harris e48ae04
error eagerly - results in a much more useful stack trace
Rich-Harris 75d093e
this always exists
Rich-Harris eb81ca5
generalize the concept of event-scoped state, since it is useful beyo…
Rich-Harris 7fb54a3
make form_instances lazy
Rich-Harris 7fde75d
make remote data lazy
Rich-Harris 2098d26
simplify
Rich-Harris 7bb4aa4
repeat
Rich-Harris 5bfd828
tweak form docs
Rich-Harris 53dfba9
prerendering error is redundant, it's all covered under SSR
Rich-Harris 2cf9b1f
unused
Rich-Harris acf64e6
oops
Rich-Harris fa71337
defer to the full docs - it's impossible to document these in isolati…
Rich-Harris 3e13995
regenerate
Rich-Harris 4a3d52c
make error handling consistent between enhanced and non-enhanced forms
Rich-Harris db246d9
remove form.error property
Rich-Harris 89af26a
regenerate
Rich-Harris a3887b7
tweak
Rich-Harris 0bd221d
make docs buildable
Rich-Harris 0dd3deb
tabs
Rich-Harris 2c5d4c8
enumerable: false is redundant
Rich-Harris d39d85f
WIP docs
Rich-Harris 8dff8c5
update tests
Rich-Harris 490ab34
remove this section for now
Rich-Harris 282285c
reuse login/register example
Rich-Harris d1931a6
formAction -> buttonProps
Rich-Harris d1b7c12
tweak docs
Rich-Harris 2d4740d
more docs updates
Rich-Harris 13e4d99
more docs
Rich-Harris d5d6c15
already covered elsewhere
Rich-Harris e19e9be
tweaks
Rich-Harris ab8e31f
docs
Rich-Harris 6bdb573
add missing since tags
Rich-Harris dada03f
regenerate
Rich-Harris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.