Skip to content

remote functions: simplify status #14046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Rich-Harris
Copy link
Member

simplifies get status and renames 'success' -> 'idle' since 'success' suggests finality (which might be okay for prerender but not for query or resources in general)

Copy link

changeset-bot bot commented Jul 25, 2025

⚠️ No Changeset found

Latest commit: c420084

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dummdidumm
Copy link
Member

idle can also mean "didn't do anything yet", so it's not directly clear that something as available.

I like Angular's resolved for this more tbh.

@Rich-Harris
Copy link
Member Author

'resolved' is the same as 'success' to me — it suggests a fait accompli. Hmm

@Rich-Harris
Copy link
Member Author

'ready' maybe?

@jjones315
Copy link

jjones315 commented Jul 25, 2025

settled is completely used when a Promise is no longer pending.

@Rich-Harris
Copy link
Member Author

'settled' would be incorrect, because when used in a promise context it encompasses error states as well

@Beiri22
Copy link

Beiri22 commented Jul 25, 2025

available?

@Rich-Harris
Copy link
Member Author

The maintainers discussed this offline earlier, and decided we're better off just removing status altogether in favour of independent loading and ready booleans. Between these and the error property you have all the information you need

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants