feat: Server-side version of query.set() to avoid re-calling the query function when unnecessary
#14304
Conversation
🦋 Changeset detectedLatest commit: 5e58402 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| onMount(() => { | ||
| const ws = new WebSocket('/ws'); | ||
| ws.addEventListener('message', (ev) => { | ||
| const message = JSON.parse(ev.data); | ||
| if (message.type === 'new-post') { | ||
| getPosts().set([ | ||
| message.post, | ||
| ...getPosts().current, | ||
| ]); | ||
| } | ||
| }); | ||
| return () => ws.close(); | ||
| }); |
There was a problem hiding this comment.
this code feels racy — imagine a message is posted after getPost() runs but before the server receives the WebSocket request.
I wonder if we'd be better off with something like a form that created a new resource and then redirected to it? (though I don't think that works right now, because the query wouldn't necessarily still be cached by the time the redirect completed)
There was a problem hiding this comment.
Maybe .set needs a (oldValue) => newValue interface? That's pretty common afaik
Closes #14301
This builds on #14303. On the server,
query.set(value)now uses the same mechanism asquery.refresh()to refresh the client-side value, but without calling the query function again.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits