Skip to content

Conversation

sillvva
Copy link
Contributor

@sillvva sillvva commented Oct 15, 2025

fixes #14687

Right now, if the schema is unknown or otherwise indefinitely recursive, it treats form.fields as a field leaf instead of a field container. This makes form.fields.as() incorrectly available instead of form.fields.allIssues(). This update fixes that by ensuring form.fields is always treated as a field container.

It also exports the RemoteFormFields type so that it can be used to create wrapper components.

Examples

Pretend the function is a generic component

Before Fix

After Fix

CleanShot 2025-10-15 at 11 01 22

No test adjustments, as this is just types. You can see the difference in the example above.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2025

🦋 Changeset detected

Latest commit: 97a5b60

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

@benmccann
Copy link
Member

@sillvva I've fixed that error. If you update your branch with the latest code from main then the tests should start passing

@sillvva
Copy link
Contributor Author

sillvva commented Oct 16, 2025

@sillvva I've fixed that error. If you update your branch with the latest code from main then the tests should start passing

Thanks @benmccann! All tests passed on the second merge.

@sillvva
Copy link
Contributor Author

sillvva commented Oct 19, 2025

@dummdidumm I apologize if you're busy. Thanks for your help on PR #14748. Would I be able to get you to review this type fix as well?

In order to work around this, I've had to copy all the RemoteForm, RemoteFormFields, RemoteFormField, etc. types into my project to fix the issue. 😭

@Rich-Harris
Copy link
Member

Thank you but this isn't quite right, at least not yet. It fixes one bug but creates another, and leaves another one unsquashed. Currently:

image

With this PR:

image

@sillvva
Copy link
Contributor Author

sillvva commented Oct 19, 2025

Got it! I think I figured out a better solution. Will post an update shortly.

Updated example

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks so much!

@Rich-Harris Rich-Harris merged commit 59a2aed into sveltejs:main Oct 20, 2025
19 checks passed
@github-actions github-actions bot mentioned this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RecursiveFormFields type is missing the definition for the allIssues method

3 participants