Skip to content

Preserve server issues when doing preflight-only validation #14759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 19, 2025
Merged

Preserve server issues when doing preflight-only validation #14759

merged 5 commits into from
Oct 19, 2025

Conversation

@Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Oct 19, 2025 •
edited
Loading

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4a79f2c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris mentioned this pull request Oct 19, 2025
Merged
5 tasks
@svelte-docs-bot
Copy link

Preview: https://svelte-dev-git-preview-kit-14759-svelte.vercel.app/

@dummdidumm
Copy link
Member

is it on purpose that this is targeting main and not the other branch?

@dummdidumm dummdidumm changed the base branch from main to preflight-only October 19, 2025 18:25
@Rich-Harris
Copy link
Member Author

nope — good catch

dummdidumm
dummdidumm approved these changes Oct 19, 2025
View reviewed changes
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - didn't look closely enough at first which caused my concern-post in the related PR about client-side overriding server-side validation. I now see that it keeps all server-side issues intact for issues that are NOT overridden by client-side issues, which is indeed better.

@Rich-Harris Rich-Harris merged commit d68fdb9 into preflight-only Oct 19, 2025
17 of 18 checks passed
@Rich-Harris Rich-Harris deleted the preflight-only-merge-issues branch October 19, 2025 21:05
Rich-Harris added a commit that referenced this pull request Oct 19, 2025
@dummdidumm @Rich-Harris
feat: allow to run preflight validation only (#14744)
98aae1c 
* feat: allow to run preflight validation only

That way you can e.g. run preflight on each keystroke and full validation only on blur

* clientOnly -> preflightOnly

* Preserve server issues when doing preflight-only validation (#14759)

* preserve server issues on preflight validation, unless there are newer preflight-only issues

* sort correctly

* no longer necessary

* lint

* Update packages/kit/src/runtime/client/remote-functions/form.svelte.js

Co-authored-by: Simon H <[email protected]>

---------

Co-authored-by: Simon H <[email protected]>

---------

Co-authored-by: Rich Harris <[email protected]>
Co-authored-by: Rich Harris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Rich-Harris @dummdidumm