-
-
Notifications
You must be signed in to change notification settings - Fork 223
✨ Use custom element's JSDoc as doc for completion/hover #2879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
With support for markdown
|
With support for markdown
| sourceFile | ||
| let tags = getCustomElementsSymbols(lang, lsContainer, tsDoc).filter((t) => | ||
| t.name.startsWith(tag.tag!) | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before, only the CompletionProvider was checking the custom elements, and not the HoverProvider. So I moved the logic that extracts the custom "types" to utils.ts to share across both
|
I think it would be better to resolve the documentation in |
|
I'm away from home the next few days, but I'll look into that shortly. |
Currently, custom elements added to
SvelteHTMLElementssupports autocompletion, but no description is displayed (from the JSDoc), while their attributes support both autocompletion and JSDoc description.This PR's goal is to enable JSDoc documentation during autocompletion and hover for custom element's tags.
For example, this declaration would yield this autocomplete: