fix: migrate ConsoleLine to svelte 5 to show the right count for duplicate logs
#1434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rich-Harris
reviewed
Jul 28, 2025
Co-authored-by: Rich Harris <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Rich-Harris
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been bugging me for a while...if you have duplicate logs the counter doesn't actually go up...the reason is that
ConsoleLineis a svelte 4 component usingLogwhich is a svelte 5 class.Well at least it was before this PR 😄
A note on documentation PRs
If this is a documentation PR (i.e. changing content within
apps/svelte.dev/content/docs), then this is the wrong repository to make those changes. The content in this folder is synced from other repositories. Therefore, these changes should be made in their respective repositories (at https://github.com/sveltejs/svelte or https://github.com/sveltejs/kit, or example).Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.