-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat: allow $state in computed class fields
#17022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 307e42f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
|
||
| const member = b.member(b.this, field.key); | ||
|
|
||
| const should_proxy = field.type === '$state' && true; // TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This predates your change, but it looks like the second condition (true) is from a leftover TODO that never came to fruition? There are 2 more copies of it now in this file. (I was bothered by it when reading the source, just not enough to make a PR for it 😅 )
Also looks like at least member and should_proxy can be de-duplicated and shared between computed and non-computed branches.
Closes #17012.
As described here, the way we transform computed class fields is using a variable to deduplicate the key (to avoid side effects and the like):
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint