Skip to content

Conversation

jsonfry
Copy link
Contributor

@jsonfry jsonfry commented Nov 28, 2024

Make S3 Object eTag optional, because it's not always there.

Motivation:

I'm seeing real events without an eTag, which naturally is causing decoding failures.

Modifications:

Made S3 Object eTag optional.

Result:

S3 Object eTag is now optional...

@sebsto sebsto self-requested a review December 2, 2024 20:19
@sebsto sebsto self-assigned this Dec 2, 2024
@sebsto sebsto added kind/bug Feature doesn't work as expected. semver/none No version bump required. labels Dec 2, 2024
@sebsto sebsto merged commit 3c1161a into swift-server:main Dec 2, 2024
17 of 19 checks passed
@sebsto
Copy link
Contributor

sebsto commented Dec 2, 2024

Thank you @jsonfry for having submitted this
Merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Feature doesn't work as expected. semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants