[BoundsSafety] Work around a regression in how macro-defined bounds-s… #10993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test llvm |
hnrklssn
approved these changes
Jul 12, 2025
hnrklssn
reviewed
Jul 12, 2025
| const IdentifierInfo *AttrName = | ||
| At.printMacroName() ? At.getMacroIdentifier() : At.getAttrName(); | ||
| DB.AddTaggedVal(reinterpret_cast<uint64_t>(AttrName), | ||
| DiagnosticsEngine::ak_identifierinfo); |
There was a problem hiding this comment.
It's ak_identifierinfo because the type of the argument for diag engine (AttrName) is IdentifierInfo.
|
@swift-ci test llvm |
…afety attributes are emitted in diagnostics A recent auto-merged change from upstream d9ef62a seemed to remove the special handling on how macro-defined bounds-safety attributes are emitted in diagnostics. Adding the specialization for now to fix the test failure. The task to clean up the special handling of the macro defined attributes is tracked separately. This fixes test failures in Clang :: BoundsSafety/Sema/attributes_in_template_decls_attr_only_mode.cpp Clang :: BoundsSafety/Sema/complex-typespecs-with-bounds.c Clang :: BoundsSafety/Sema/terminated-by-attr.c Clang :: BoundsSafety/Sema/unsafe-late-const.c rdar://155652853
rapidsna
force-pushed
the
fix-printing-macro-defined-attr
branch
from
44f3518 to
2862f10
Compare
|
@swift-ci test llvm |
|
These are existing failures https://smooshbase.apple.com/ci/view/BotWrangler/job/apple-clang-stage1-RA-next/67053/testReport/ Failed Tests (6): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…afety attributes are emitted in diagnostics
A recent auto-merged change from upstream
d9ef62a
seemed to remove the special handling on how macro-defined bounds-safety attributes are emitted in diagnostics. Adding the specialization for now to fix the test failure. The task to clean up the special handling of the macro defined attributes is tracked separately.
This fixes test failures in
Clang :: BoundsSafety/Sema/attributes_in_template_decls_attr_only_mode.cpp
Clang :: BoundsSafety/Sema/complex-typespecs-with-bounds.c
Clang :: BoundsSafety/Sema/terminated-by-attr.c
Clang :: BoundsSafety/Sema/unsafe-late-const.c
rdar://155652853