Add log messages for when a process gets terminated because the task is cancelled #2206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
…is cancelled I hope this makes it easier to spot why a `swift build` launched for target preparation does not get terminated when the preparation task is cancelled, as we saw in https://ci-external.swift.org/job/sourcekit-lsp-PR-windows/3089/.
ahoppen
force-pushed
the
log-process-termination
branch
from
efc1d53 to
70ec1bf
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
bnbarham
approved these changes
Jul 15, 2025
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this makes it easier to spot why a
swift buildlaunched for target preparation does not get terminated when the preparation task is cancelled, as we saw in https://ci-external.swift.org/job/sourcekit-lsp-PR-windows/3089/.