A couple refactorings to necessary to support multi-file indexing #2280
+170
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The document wasn’t used in here.
…skDescription` This way we can guarantee that all files passed to `UpdateIndexStoreTaskDescription` belong to the same target, which will simplify multi-file indexing.
…le files This pushes multi-file indexing one level closer to the actual compiler invocation.
ahoppen
requested review from
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci Please test |
ahoppen
force-pushed
the
file-index-batching-preparation
branch
from
b468491 to
cbf9fee
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
…the same language It doesn’t make sense to try and index files with different langauges in a single compiler invocation.
ahoppen
force-pushed
the
file-index-batching-preparation
branch
from
cbf9fee to
7860893
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
bnbarham
approved these changes
Sep 5, 2025
| @@ -722,16 +737,20 @@ package final actor SemanticIndexManager { | |||
| } | |||
| } | |||
|
|
|||
| /// Update the index store for the given files, assuming that their targets have already been prepared. | |||
| /// Update the index store for the given files, assuming that their targets has already been prepared. | |||
There was a problem hiding this comment.
Suggested change
| /// Update the index store for the given files, assuming that their targets has already been prepared. | |
| /// Update the index store for the given files, assuming that their target has already been prepared. |
But part of some later PR is fine, testing has already run on this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed commit by commit. It doesn’t do anything by itself, the goal is to ensure that
UpdateIndexStoreTaskDescriptioninstances only has files from a single target and a single language, without which it doesn’t make sense to index multiple files in the same compiler invocation.