Take the host platform into account when writing clang response files #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
aciidgh,
jakepetroules,
mhrawdon and
neonichu
as code owners
|
@swift-ci test |
owenv
force-pushed
the
owenv/clang-resp
branch
from
07f8af4 to
9574235
Compare
|
@swift-ci test |
owenv
force-pushed
the
owenv/clang-resp
branch
from
9574235 to
5e80741
Compare
|
@swift-ci test |
jakepetroules
approved these changes
Sep 22, 2025
| } | ||
|
|
||
| public var defaultResponseFileFormat: ResponseFileFormat { | ||
| switch self { |
There was a problem hiding this comment.
nit: use this?
self == .windows ? .windowsShellQuotedNewlineSeparated : .unixShellQuotedSpaceSeparatedSeems unlikely there will ever be difference except for Windows
neonichu
approved these changes
Sep 22, 2025
|
I tested this locally but the |
|
@daveinglis possibly, we may need to dig into the clang implementation a bit to see what it's expecting to receive |
daveinglis
approved these changes
Sep 24, 2025
|
Closing this one for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the contents get properly escaped