Mock out time itself in the elapsed timer and rate limiter tests #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakepetroules
requested review from
aciidgh,
mhrawdon,
neonichu and
owenv
as code owners
Collaborator
Author
|
@swift-ci test |
jakepetroules
force-pushed
the
eng/PR-time-control
branch
from
93a3a5d to
8c865b8
Compare
Collaborator
Author
|
@swift-ci test |
These occasionally fail nondeterministically; remove the property which allows them to do so (timing). This also fixes some "off by one" errors that relying on a mock clock revealed -- there was an implicit assumption that sleep() would take a bit more time than requested, and environments with extreme timing sensitivity sometimes failed to do so.
jakepetroules
force-pushed
the
eng/PR-time-control
branch
from
8c865b8 to
7ffbf57
Compare
Collaborator
Author
|
@swift-ci test |
neonichu
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These occasionally fail nondeterministically; remove the property which allows them to do so (timing).
This also fixes some "off by one" errors that relying on a mock clock revealed -- there was an implicit assumption that sleep() would take a bit more time than requested, and environments with extreme timing sensitivity sometimes failed to do so.