Handle "-internal-import-bridging-header" #1993
Conversation
Driver part of rdar://74011750.
|
@swift-ci please test |
| self.importBridgingHeaderAsInternal = importBridgingHeaderOption.option == .internalImportBridgingHeader | ||
| } else { | ||
| self.originalObjCHeaderFile = nil | ||
| self.importBridgingHeaderAsInternal = false |
There was a problem hiding this comment.
I think this is not quite correct. I think it maybe need to be internal if library evolution is enabled.
The special case that falls here is that the current module doesn't have a bridging header but there is dependency swift binary module that has bridging header, thus scanner can create a chained bridging for current module. In this case, there isn't a bridging header import flag that indicates if current module does internal import or not.
There was a problem hiding this comment.
I don't think I understand how to construct this special case. In the place where the driver used to always generate -import-pch for the chained header, it now checks whether the bridging header is internal and will pass the new -internal-import-pch instead (which treats the PCH as internal-only). Is that not sufficient?
There was a problem hiding this comment.
A swift testcase for this is: https://github.com/swiftlang/swift/blob/main/test/ScanDependencies/bridging-header-autochaining.swift#L51-L55
Requirement is:
- Module has no bridging header
- Binary module dependency has bridging header
- Enable auto chaining.
In this case, driver invocation will not have -*import-bridging-header, swift-driver needs to figure out which -import-pch flag flavor to pass the PCH flag to swift-frontend.
There was a problem hiding this comment.
When the binary module dependency has an internal bridging header (the new thing), it's not recorded that it has a bridging header at all, so there is no chaining. No?
There was a problem hiding this comment.
In my example, internal bridging header is not using internal bridging header, but the legacy bridging header.
|
@swift-ci please test Windows |
The bridging header is effectively imported as a "public" import. This new option makes it an "internal" import, so that entities accessible via the bridging header cannot be part of public API.
Driver part of rdar://74011750.