Skip to content

Enable FoundationMacrosTests on Windows #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jmschonfeld
Copy link
Contributor

@jmschonfeld jmschonfeld commented Jul 14, 2025

In recent main/6.2 snapshots (since ~early May) SwiftPM now supports building targets that depend on executables (like macro tests which depend on the macro executable) like we do on Linux and macOS. Now that this limitation has been resolved, we can enable our macro tests on Windows

@jmschonfeld jmschonfeld marked this pull request as ready for review July 14, 2025 20:41
@jmschonfeld
Copy link
Contributor Author

@swift-ci please test

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it builds, why not. However, I'd be curious to know how this was "fixed" (/alternatename: doesn't give the desired behaviour AFAIK).

@jmschonfeld
Copy link
Contributor Author

If it builds, why not. However, I'd be curious to know how this was "fixed" (/alternatename: doesn't give the desired behaviour AFAIK).

@daveinglis mentioned that it was fixed by swiftlang/swift-package-manager#8515. I was expecting this to fix the more general problem with test targets that depend on an executable, but I think macro tests are just a specific type of target in this category so I figured I'd give re-enabling this a shot and it looks like it builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants