Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 2, 2025

This PR was automatically opened by a GitHub action. Review the changes included in this PR and determine if they should be included in the release branch. If yes, merge the PR. Otherwise revert changes that should not be included on this branch.

itingliu and others added 2 commits October 31, 2025 09:51
…hange (#1562)

* localizedName_103036605() fails when the current date is around DST change

We saw a test failure in this CI job: https://ci.swift.org/job/oss-swift-6.2-bootstrap-ubuntu-24_04-x86_64/318

```
[2025-10-26T00:58:39.054Z] ✘ Test localizedName_103036605() recorded an issue at TimeZoneTests.swift:74:13: Expectation failed: (tz?.localizedName(for: .generic, locale: locale) → "Central European Time (Germany)") == (expected → "Central European Time")
```

The cause of this test failure is that this `TimeZone` API uses the current time as reference, and depending on `style` it may include the time zone city to disambiguate that from the [golden zone](https://www.unicode.org/reports/tr35/tr35-dates.html#Using_Time_Zone_Names) if the current time is close to a DST transition.

Update the test to use the golden zone to opt out of this unexpected behavior since that is not what this test was meant to test.

Also while we're here, update the test to respect the `style` argument.

* Add another expectation for when observing DST

* Use a fairly stable timezone for test

The time zone offset for Vostok recently went through a change. Udpate the test to use a stable time zone for this test
…01_09-03

Merge `release/6.2` into `main`
@jmschonfeld jmschonfeld closed this Nov 2, 2025
@jmschonfeld jmschonfeld reopened this Nov 2, 2025
@jmschonfeld jmschonfeld marked this pull request as ready for review November 2, 2025 17:38
@jmschonfeld jmschonfeld merged commit bfdb63b into future Nov 2, 2025
20 checks passed
@jmschonfeld jmschonfeld deleted the automerge/merge-main-2025-11-02_09-03 branch November 2, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants