swift-package-migrate: Call SwiftFixIt once for all diagnostic files #8933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
requested review from
bkhouri,
bnbarham,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand,
shawnhyam and
xedin
as code owners
Contributor
Author
|
@swift-ci please test macOS Platform |
owenv
approved these changes
Jul 14, 2025
xedin
approved these changes
Jul 14, 2025
Contributor
Author
|
@swift-ci please test |
Also tidy up excluded directory checks in the diagnostic filter and add missing `@Test` to a test function.
This excludes the possibility of repeated fix-it application caused by accidental emission of migration warnings in dependency modules. Also add a comment for why we exclude plugins from migration.
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test macOS self hosted |
Contributor
Author
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This excludes the possibility of repeated fix-it application caused by accidental emission of migration warnings in dependency modules.
Modifications:
Also:
SwiftFixIttest for directory exclusion.@TesttoSwiftFixIttest.