[6.2] swift-package-migrate: Call SwiftFixIt once for all diagnostic files #8961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also tidy up excluded directory checks in the diagnostic filter and add missing `@Test` to a test function. (cherry picked from commit bcf6049)
This excludes the possibility of repeated fix-it application caused by accidental emission of migration warnings in dependency modules. Also add a comment for why we exclude plugins from migration.
AnthonyLatsis
requested review from
bnbarham,
xedin,
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci please test |
bnbarham
approved these changes
Jul 22, 2025
|
@swift-ci please test macOS |
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: This excludes the possibility of repeated fix-it application caused by accidental emission of migration warnings in dependency modules. Also:
SwiftFixIttest for directory exclusion.@TesttoSwiftFixIttest.Scope:
swift package migrate.Issues: —
Original PRs: swift-package-migrate: Call SwiftFixIt once for all diagnostic files #8933.
Risk: Low.
Testing: The filtering this change relies on is already properly tested in
SwiftFixItTests.Reviewers: @xedin @owenv