[SwiftBuild] Use hostBuildTool product type for build plugin targets
#8936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rgets Match how macros are handled and use the `hostBuildTool` product type. rdar://155792370
hamishknight
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci please test |
MaxDesiatov
changed the title
hostBuildTool product type for SPM build plugin targetshostBuildTool product type for build plugin targets
bkhouri
reviewed
Jul 15, 2025
| @@ -39,7 +39,7 @@ extension PackagePIFProjectBuilder { | |||
| let pluginTargetKeyPath = try self.project.addTarget { _ in | |||
| ProjectModel.Target( | |||
| id: pluginModule.pifTargetGUID, | |||
| productType: .executable, | |||
| productType: .hostBuildTool, | |||
There was a problem hiding this comment.
suggestion: can we add an automated tests to ensure we don't regress in the future?
There was a problem hiding this comment.
As far as I could tell, we don't really have any existing unit tests for this logic, only integration tests, unless I'm overlooking something?
There was a problem hiding this comment.
I agree adding more test coverage would be beneficial.
@pmattos Did you add any tests for the PIF generation in libSwiftPM?
There was a problem hiding this comment.
No, I didn't... only those on the Xcode side of things.
We do have XCBuild PIF tests that we plan to port over eventually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match how macros are handled and use the
hostBuildToolproduct type.rdar://155792370