Ensure call to unsafe_await is not called from Swifts concurrency system #9490
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rconnell9
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv and
plemarquand
as code owners
jakepetroules
approved these changes
Dec 10, 2025
Contributor
Author
|
@swift-ci test |
bkhouri
reviewed
Dec 10, 2025
| public func unsafe_await<T: Sendable>(_ body: @Sendable @escaping () async -> T) -> T { | ||
| withUnsafeCurrentTask { task in | ||
| if task != nil { | ||
| fatalError("This function must not be invoked from the Swift Concurrency thread pool.") |
Contributor
There was a problem hiding this comment.
question: will the fatal error contains the function reference? if not, consider replading function with \(#function) and maybe even include \(#file) somewhere in the message .
Contributor
There was a problem hiding this comment.
Good call, but only if passing in #function as a default parameter argument, otherwise it will be constant, which isn't that useful.
I think backtraces give you most of the value anyways.
Contributor
Author
|
@swift-ci test |
1 similar comment
Contributor
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure call to unsafe_await is not called from Swifts concurrency system
Motivation:
Defensive check in response to:
#9441
Modifications:
Ensure call to unsafe_await is not called from Swift's concurrency system (an asynchronous context).