Use dedicated thread when invoking buildSystem.build() as it is a blocking operation #9493
+24
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rconnell9
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv and
plemarquand
as code owners
Contributor
Author
|
@swift-ci test |
jakepetroules
approved these changes
Dec 11, 2025
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test macOS |
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci test macos self hosted |
1 similar comment
Contributor
Author
|
@swift-ci test macos self hosted |
Contributor
Author
|
@swift-ci test windows |
owenv
approved these changes
Dec 11, 2025
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci test macOS self hosted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Task.detachNewThread here because buildSystem.build() is a blocking operation. Running this on the Swift Concurrency thread pool can block a worker thread potentially causing thread pool starvation and deadlocks. By running it on a dedicated thread, we keep the Swift Concurrency pool available for other async work.
Motivation:
#9441