[WIP] Use prebuilts for all targets that build for destination == host. #9499
+543
−317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a hidden HostCondition that will check the build parameters to see if we're building a target for host enable the include and link settings to use the prebuilts and disable the dependency on swift-syntax products. Doesn't support SwiftBuild yet. Need to figure out how to use the same condition there. Also cleaned up BuildPlanTests so they are just Native BuildPlan tests as designed and created a separate BuildTests for the two tests that used the build system kind setting.
dschaefer2
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
jakepetroules,
owenv,
plemarquand and
rconnell9
as code owners
Member
Author
|
@swift-ci please test |
bripeticca
approved these changes
Dec 11, 2025
| /// A configuration condition implies that an assignment is valid on | ||
| /// a particular build configuration. | ||
| /// By the time we get to evaluating the condition, the package loader would have filtered out | ||
| /// disabled traits. As such, this should always evaluate to true. |
Contributor
There was a problem hiding this comment.
praise: thank you for updating this description!
Member
Author
|
BTW, Will get SwiftBuild working before this is ready. |
dschaefer2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a hidden HostCondition that will check the build parameters to see if we're building a target for host enable the include and link settings to use the prebuilts and disable the dependency on swift-syntax products.
Doesn't support SwiftBuild yet. Need to figure out how to use the same condition there.
Also cleaned up BuildPlanTests so they are just Native BuildPlan tests as designed and created a separate BuildTests for the two tests that used the build system kind setting.