Ignore ExpectationFailedError when thrown by the body closure passed to withKnownIssue #1441
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where a redundant, second known issue is recorded when
try #require()fails within the body closure ofwithKnownIssue. For example, in the following example code:two (known) issues are recorded:
Of these, only the first should be recorded and the second should be suppressed.
Fixes rdar://153550847
Motivation:
It should be possible to use
try #require()in the body closure passed towithKnownIssue, and matching failures should only cause a single known issue to be recorded. The second issue shown above describes an infrastructuralError-conforming type which is not generally intended to be included in the results test authors see, and can cause confusion.Modifications:
withKnownIssuebody closure, ignore the error if it's of type `ExpectationFailedError.Checklist: