[cxx-interop] Emit #endif // defined(__OBJC__) with the comment consistently
#85439
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorzhdan
requested review from
Xazax-hun,
j-hui and
susmonteiro
as code owners
Contributor
Author
|
@swift-ci please smoke test |
j-hui
approved these changes
Nov 11, 2025
…sistently This makes sure that whenever we emit `#if defined(__OBJC__)`, the matching `#endif` has a comment `// defined(__OBJC__)`. This makes both testing and reading the header file easier.
egorzhdan
force-pushed
the
egorzhdan/endif-objc
branch
from
9d15318 to
8cafef0
Compare
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please test Windows |
1 similar comment
Contributor
Author
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that whenever we emit
#if defined(__OBJC__), the matching#endifhas a comment// defined(__OBJC__).This makes both testing and reading the header file easier.