[Sema] Skip type-checking catch bodies when computing the bound error type #85449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
bnbarham,
hborla,
rintaro,
slavapestov and
xedin
as code owners
Sink the assertion down into `TypeChecker::typeCheckCondition` and remove the old logic.
…or type Make sure we only ever type-check the `do` body of a `do-catch` statement when lazily type-checking the bound error type, which we can do for completion. rdar://164481242
hamishknight
force-pushed
the
whats-the-catch
branch
from
82d3f11 to
14608cb
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test source compatibility |
Contributor
Author
|
@swift-ci please SourceKit stress test |
xedin
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we only ever type-check the
dobody of ado-catchstatement when lazily type-checking the bound error type, which we can do for completion.Resolves #85434
rdar://164481242