Skip to content

Conversation

@roulpriya
Copy link
Contributor

@roulpriya roulpriya commented Jul 14, 2025

Description

  • Refactored Swiftly code from toolchain.ts to swiftly.ts
  • Added list-available with json output

Issue: #1739

Tasks

  • Required tests have been written
  • Documentation has been updated
  • Added an entry to CHANGELOG.md if applicable

Copy link
Member

@matthewbastien matthewbastien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few things to clean up and a question about the failure paths for swiftlyToolchain().

Copy link
Member

@matthewbastien matthewbastien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. Meant to request changes, not approve.

@roulpriya roulpriya force-pushed the list-available-toolchain branch from 5a07f8b to 68790c8 Compare July 16, 2025 13:04
@roulpriya roulpriya marked this pull request as ready for review July 16, 2025 17:49
Copy link
Contributor

@award999 award999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@roulpriya roulpriya force-pushed the list-available-toolchain branch from 25a4344 to 0048272 Compare July 17, 2025 17:23
Copy link
Member

@matthewbastien matthewbastien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you!

@matthewbastien matthewbastien merged commit 7124b9a into swiftlang:main Jul 18, 2025
18 checks passed
@award999 award999 added the needs verification Issue has been fixed, but requires verification before closing label Jul 22, 2025
@award999 award999 moved this to Needs Verification in Swift Extension for Visual Studio Code Jul 22, 2025
@award999 award999 removed the needs verification Issue has been fixed, but requires verification before closing label Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants