Improve Swiftly installation progress notification #1901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbastien
requested review from
0xTim,
adam-fowler and
award999
as code owners
award999
reviewed
Oct 23, 2025
| ) { | ||
| const increment = progressData.step.percent - lastProgress; | ||
| if (progressData.complete) { | ||
| // Swiftly will also verify the signature and extract the toolchain after the |
There was a problem hiding this comment.
how funky would it be to popup a withProgress notification? That way at least get the progress animation
There was a problem hiding this comment.
This is within a withProgress notification. Resetting the progress to 0 resets the animation.
award999
reviewed
Oct 23, 2025
|
|
||
| "lib": ["ES2021"], | ||
| "target": "ES2020", | ||
| "lib": ["ES2022"], |
There was a problem hiding this comment.
why do we need to bump for this change?
There was a problem hiding this comment.
This is to get error causations. So, you can provide a cause (kind of like in Java) for your errors:
try {
// Do something that will throw
} catch (error) {
throw new Error("Something went wrong", { cause: error });
}NodeJS will print the stack trace of both errors in this case so that we don't have to do this manually like what was in the existing code.
award999
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Swiftly performs a signature verification and extraction of the toolchain even after the download completes. Show a notification in this case and reset the progress to indicate to the user that Swiftly is still performing some work.
Tasks
[ ] Required tests have been written[ ] Documentation has been updated[ ] Added an entry to CHANGELOG.md if applicable