Skip to content

feat(styles): Added position boostrap classes in Design System #4863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 23 commits into from
Closed

feat(styles): Added position boostrap classes in Design System #4863

wants to merge 23 commits into from

Conversation

@veyaromain
Copy link
Contributor

No description provided.

@veyaromain veyaromain requested a review from a team as a code owner March 4, 2025 07:28
@veyaromain veyaromain linked an issue Mar 4, 2025 that may be closed by this pull request
Bootstrap helpers: Position (< 100) #4236
Closed
@veyaromain veyaromain requested a review from leagrdv March 4, 2025 07:28
@changeset-bot
Copy link

changeset-bot bot commented Mar 4, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 32dda11

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@swisspost/design-system-styles Major
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components Major
@swisspost/design-system-documentation Patch
@swisspost/internet-header Major
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-styles-primeng Major
@swisspost/design-system-components-react Major
@swisspost/design-system-components-angular Major
@swisspost/design-system-tokens Major
@swisspost/design-system-icons Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Mar 19, 2025 •
edited
Loading

Related Previews

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

leagrdv
leagrdv requested changes Apr 8, 2025
View reviewed changes
.changeset/big-zoos-wash.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have those helper classes documented. Could you add a section for this in the Utilities/Position in the docs? As well as adding visual tests in the position.snapshot.stories.ts file

@alizedebray
Merge remote-tracking branch 'origin/main' into 4236-bootstrap-helper…
b65fb13 
…s-position-100

# Conflicts:
#	packages/styles/src/themes/bootstrap/_utilities.scss
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@alizedebray alizedebray added the needs: 🏓 dev roundtable To be discussed at the roundtable of esteemed developers label Aug 5, 2025
@alizedebray
Copy link
Contributor

alizedebray commented Aug 5, 2025 •
edited
Loading

These classes seem redundant since we already have position utility classes: https://next.design-system.post.ch/?path=/docs/803a58e8-c734-4ad7-80a8-62da1bb29d4b--docs

The only added property is the z-index, can we simply create utility classes with fixed z-indexes to place something above the page content or above the header? (we already have relative z-index utility classes: #5741)

gfellerph
gfellerph reviewed Aug 7, 2025
View reviewed changes
Copy link
Member

@gfellerph gfellerph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev roundtable resolution: implement z-index utilities for named z-indices and provide automigrations for previous uses of the combined utility classes to migrate them to composable utility classes.

@gfellerph gfellerph removed the needs: 🏓 dev roundtable To be discussed at the roundtable of esteemed developers label Aug 7, 2025
@alizedebray alizedebray mentioned this pull request Aug 11, 2025
Closed
2 tasks
@alizedebray alizedebray deleted the 4236-bootstrap-helpers-position-100 branch August 13, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gfellerph gfellerph gfellerph left review comments

@leagrdv leagrdv leagrdv requested changes

Assignees

@alizedebray alizedebray

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bootstrap helpers: Position (< 100)

5 participants

@veyaromain @swisspost-bot @alizedebray @gfellerph @leagrdv