-
Notifications
You must be signed in to change notification settings - Fork 19
feat(documentation): investigate and document cross component dom referencing #5524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
myrta2302
wants to merge
29
commits into
main
from
5300-investigate-and-document-cross-component-dom-referencing
Closed
feat(documentation): investigate and document cross component dom referencing #5524
myrta2302
wants to merge
29
commits into
main
from
5300-investigate-and-document-cross-component-dom-referencing
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
π¦ Changeset detectedLatest commit: cde59b4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Related Previews |
β¦t-dom-referencing
β¦nts/src/components/ subfolder names (#5165)
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | actions/checkout | action | digest | `85e6279` -> `09d2aca` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Configuration π **Schedule**: Branch creation - "before 4am on the first day of the month" in timezone Europe/Zurich, Automerge - At any time (no schedule defined). π¦ **Automerge**: Disabled by config. Please merge this manually once you are satisfied. β» **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. π **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/swisspost/design-system). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC40OC41IiwidXBkYXRlZEluVmVyIjoiNDAuNDguNSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsi4puT77iPIGRlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | changesets/action | action | digest | `06245a4` -> `04d574e` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Configuration π **Schedule**: Branch creation - "before 4am on the first day of the month" in timezone Europe/Zurich, Automerge - At any time (no schedule defined). π¦ **Automerge**: Disabled by config. Please merge this manually once you are satisfied. β» **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. π **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/swisspost/design-system). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC40OC41IiwidXBkYXRlZEluVmVyIjoiNDAuNDguNSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsi4puT77iPIGRlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
#5611) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | dawidd6/action-download-artifact | action | digest | `07ab29f` -> `9b54a0a` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Configuration π **Schedule**: Branch creation - "before 4am on the first day of the month" in timezone Europe/Zurich, Automerge - At any time (no schedule defined). π¦ **Automerge**: Disabled by config. Please merge this manually once you are satisfied. β» **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. π **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/swisspost/design-system). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC40OC41IiwidXBkYXRlZEluVmVyIjoiNDAuNDguNSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsi4puT77iPIGRlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
β¦r word wrapping and updating width constraints (#5544) ## π Description - Updated `max-width` from 200px to 280px for better content accommodation - Implemented proper word breaking for content that exceeds container width --- ## π Checklist - β My code follows the style guidelines of this project - π οΈ I have performed a self-review of my own code - π I have made corresponding changes to the documentation -β οΈ My changes generate no new warnings or errors - π§ͺ I have added tests that prove my fix is effective or that my feature works - βοΈ New and existing unit tests pass locally with my changes Co-authored-by: Alona <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Oliver SchΓΌrch <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
β¦OS devices/Chrome (#5550) ## πBug Floating labels from form inputs remain visible above the mobile navigation menu on iOS devices in Chrome browsers, breaking the expected visual hierarchy and potentially obscuring menu content. π οΈ To Reproduce Steps to reproduce the behavior: - Go to https://www.swisspost-cargo.com/ch-en/help-and-contact on an iPhone - Start filling up the input fields (at least 2) - Open the mobile navigation menu - The floating labels are displayed above the menu ## Device Iphone15 ## PR description Adjusted z-index hierarchy to ensure proper layering: increased `post-header` components z-indexes by 1 on mobile and tablet devices to maintain correct stacking order during iOS's automatic zoom behavior on form inputs. ## π Demo  ## π Checklist - β My code follows the style guidelines of this project - π οΈ I have performed a self-review of my own code - π I have made corresponding changes to the documentation -β οΈ My changes generate no new warnings or errors - π§ͺ I have added tests that prove my fix is effective or that my feature works - βοΈ New and existing unit tests pass locally with my changes --------- Co-authored-by: Alona <[email protected]>
β¦tigate-and-document-cross-component-dom-referencing
β¦d interfering with layout (#5574) ## π Description This PR sets the display of `<post-tooltip>` to `display: contents` to ensure it does not cause any layout shifts. ## π Checklist - β My code follows the style guidelines of this project - π οΈ I have performed a self-review of my own code - π I have made corresponding changes to the documentation -β οΈ My changes generate no new warnings or errors - βοΈ New and existing unit tests pass locally with my changes
β¦pixel gap at 125% scaling (#5547) ## π Description This PR adjusts textarea floating label top position to prevent text from appearing between label and border on Windows at 125% scaling. ## π Checklist - β My code follows the style guidelines of this project - π οΈ I have performed a self-review of my own code -β οΈ My changes generate no new warnings or errors - βοΈ New and existing unit tests pass locally with my changes
## π Description This PR adds a new page 'Header with Custom Logo Link' under Guidelines, on how to use post-header logo with a custom link wrapper. ## π Checklist - β My code follows the style guidelines of this project - π οΈ I have performed a self-review of my own code - π I have made corresponding changes to the documentation -β οΈ My changes generate no new warnings or errors - βοΈ New and existing unit tests pass locally with my changes --------- Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: Oliver SchΓΌrch <[email protected]>
β¦ocumentation` workflows (#5344) - [x] Depends on #5343 Ticket: https://github.com/orgs/swisspost/projects/3/views/11?pane=issue&itemId=105001281&issue=swisspost%7Cdesign-system%7C5191 ## π Description Enhance deployment workflow security by: - Validating issue numbers and netlify configs - Sanitizing all user inputs before use - Using safer scripting methods ## π Demo If applicable, please add a screenshot or video to illustrate the changes. --- ## π Checklist - β My code follows the style guidelines of this project - π οΈ I have performed a self-review of my own code - π I have made corresponding changes to the documentation -β οΈ My changes generate no new warnings or errors - π§ͺ I have added tests that prove my fix is effective or that my feature works - βοΈ New and existing unit tests pass locally with my changes --------- Co-authored-by: Alona <[email protected]>
β¦encing' into 5300-create-demo-web-components
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Description
comes after -> #5618 and #5629
π Checklist